Skip to content

Commit

Permalink
Create remote.Push (#1978)
Browse files Browse the repository at this point in the history
This exposes a function with the same signature as `remote.{Tag,Put}` using `Taggable` but that has the semantics of `remote.Write[Index` wrt writing the consituent elements of the taggable.

Signed-off-by: Matt Moore <[email protected]>
  • Loading branch information
mattmoor authored Jul 17, 2024
1 parent d36047a commit c3d1dcc
Showing 1 changed file with 14 additions and 16 deletions.
30 changes: 14 additions & 16 deletions pkg/v1/remote/write.go
Original file line number Diff line number Diff line change
Expand Up @@ -45,14 +45,7 @@ type Taggable interface {

// Write pushes the provided img to the specified image reference.
func Write(ref name.Reference, img v1.Image, options ...Option) (rerr error) {
o, err := makeOptions(options...)
if err != nil {
return err
}
if o.progress != nil {
defer func() { o.progress.Close(rerr) }()
}
return newPusher(o).Push(o.context, ref, img)
return Push(ref, img, options...)
}

// writer writes the elements of an image to a remote image reference.
Expand Down Expand Up @@ -656,14 +649,7 @@ func scopesForUploadingImage(repo name.Repository, layers []v1.Layer) []string {
// WriteIndex will attempt to push all of the referenced manifests before
// attempting to push the ImageIndex, to retain referential integrity.
func WriteIndex(ref name.Reference, ii v1.ImageIndex, options ...Option) (rerr error) {
o, err := makeOptions(options...)
if err != nil {
return err
}
if o.progress != nil {
defer func() { o.progress.Close(rerr) }()
}
return newPusher(o).Push(o.context, ref, ii)
return Push(ref, ii, options...)
}

// WriteLayer uploads the provided Layer to the specified repo.
Expand Down Expand Up @@ -711,3 +697,15 @@ func Put(ref name.Reference, t Taggable, options ...Option) error {
}
return newPusher(o).Put(o.context, ref, t)
}

// Push uploads the given Taggable to the specified reference.
func Push(ref name.Reference, t Taggable, options ...Option) (rerr error) {
o, err := makeOptions(options...)
if err != nil {
return err
}
if o.progress != nil {
defer func() { o.progress.Close(rerr) }()
}
return newPusher(o).Push(o.context, ref, t)
}

0 comments on commit c3d1dcc

Please sign in to comment.