pkg/registry: Export errNotFound #1940
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This Pull Request is stale because it has been open for 90 days with |
|
Can anybody take a look at this? |
|
Just ran into this issue myself. It would be great if we could get this CL merged :) |
|
@jonjohnsonjr would you mind giving this a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The registry logic checks for the unexported error
errNotFoundduring blob handling.When implementing a custom
BlobHandleroutside of this package the developer is unable to use the unexportederrNotFoundvariable, therefore the customBlobHandlercannot signal the correct error to the registry package which results in a wrong execution flow.This PR exposes the
ErrNotFounderror so it can be used from outside the registry package, this aligns with other packages in this module that use the same approach e.g. cache