Fix "crane layout gc" failing on Windows wit "Error: cannot parse hash: "sha256\\0401ae60059.." (#1942)

[bartoszpop]

This pull request updates "layout gc" to use os-specific path separator instead of "/" (fixes #1942).

[bartoszpop]

@imjasonh @thesayyn @jonjohnsonjr would you have some time to review? it is blocking us from migrating to Bazel

[martianoff]

nice catch

[bartoszpop]

@imjasonh any chance to have it merged?

[thesayyn]

Can you add some tests for this?

[thesayyn]

it is blocking us from migrating to Bazel

If you need this for rules_oci, i might interest you in rules_oci 2.x which probably wouldn't have this problem.

[martianoff]

rules_oci 2.x

i've tried but it doesn't work on windows due to other issues

[bartoszpop]

@thesayyn the unit test is already there. gc_test.go#TestGcIndex fails on Windows without the above fix:

--- FAIL: TestGcIndex (0.00s)
gc_test.go:39: GarbageCollect() = cannot parse hash: "sha256\05f95b26ed10668b7183c1e2da98610e91372fa9f510046d4ce5812addad86b5"

Also, os.PathSeparator is a constant hence it cannot be modified at runtime for unit test purposes.

[bartoszpop]

@imjasonh @thesayyn @jonjohnsonjr can you please merge this fix? When is the next release planned?

[bartoszpop]

@mattmoor is there a chance you could merge this pr and release?

[github-actions]

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Keep fresh with the 'lifecycle/frozen' label.