Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1200: POC for WithMirror transport #2010

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

sherine-k
Copy link

This is my first PR to this repository.

This PR doesn't aim to fix #1200 (yet) : This is just an initial attempt to do so.

I'm submitting this in order to initiate the discussion started in #1200 around the implementation, and acknowledge that:

  • I wasn't able to successfully run ./hack/presubmit.sh: It complains about absence of cmp and cpu under the internal folder
  • I didn't implement any unit tests so far, but will do so after we validate together the direction for this PR
  • Some things are still hard coded, and I need to fix those things after getting a green light for continuing

Thanks for the opportunity, and looking forward to contributing

@mepi262
Copy link

mepi262 commented Nov 22, 2024

@jonjohnsonjr @mattmoor @imjasonh cc @sherine-k
The reviewee wants to discuss this pull request. With Whom is it appropriate to discuss it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FR: Support a WithMirror option
2 participants