Support Properties subclasses in GsonTypes.getMapKeyAndValueTypes #2758
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a
TODO
in this method that calls to test it with theProperties
subclasses. They are supposed to returnnew Type[] {String.class, String.class}
, just like if you cast theProperties
class itself. But still when you pass a subclass ofProperties
, such asCustomProperties
, the method returnsnew Type[] {Object.class, Object.class}
, which is incorrect. Here I tried to fix this problem by usingisAssignableFrom()
and also wrote tests which indicate that the problem is solved