Re-add WithinTolerance validator with tests (#920) #968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: lalten <[email protected]>
JamesMTSloan
referenced
this pull request
Nov 23, 2020
* Drop py2.7 tests from travis config and setup.py. * diagnoses_lib: Serialize diagnoses result values, not names Diagnosis results should values should be serialized out rather than the enum constant names. PiperOrigin-RevId: 318469885 * Attachments: Handle case where NamedTemporaryFile object stops working. We have noticed times where we get bad file descriptor exceptions trying to reload data from the temporary files. For now, just return empty byte strings while we investigate more. Also, adding a callback to close the Attachments' temporary files. PiperOrigin-RevId: 319879865 * test_record: Fix lint issues. PiperOrigin-RevId: 320025482 * output callbacks: Fix CloseAttachments Attachments are stored in a dictionary under the phase record, not a list. PiperOrigin-RevId: 321406529 * OpenHTF: Fix lint issues and run autoformatter. PiperOrigin-RevId: 323661267 * Initial pytype-based type annotations. PiperOrigin-RevId: 324720299 * conf: Use inspect.getfullargspec. PiperOrigin-RevId: 324754078 * Internal change PiperOrigin-RevId: 325271171 * Only have the attachment's temporary file open while reading/writing. If there are a lot of attachments, the program can exceed Linux's max allowed open files per process. PiperOrigin-RevId: 325490340 * Add core annotations and replace mutablerecords and namedtuple with attr. PhaseDescriptor will be in the next commit. PiperOrigin-RevId: 327075946 * Rearrange and add comments for the Measurement fields. PiperOrigin-RevId: 327140593 * Internal change PiperOrigin-RevId: 327735936 * Convert PhaseOptions and PhaseDescriptor to attr. PiperOrigin-RevId: 328778682 * callbacks: Add type annotations Add type annotations to the callbacks library and break apart some complex types. Also breaking out the JSON conversion logic to an independent function for easier use by other modules. PiperOrigin-RevId: 328972148 * Internal change PiperOrigin-RevId: 329550447 * Internal change PiperOrigin-RevId: 331590164 * Internal change PiperOrigin-RevId: 331890539 * Remove TestPhase alias. The TestPhase alias for PhaseOptions has long been deprecated. Removing it. PiperOrigin-RevId: 332291802 * Add more type annotations. PiperOrigin-RevId: 332519023 * Remove plugs-phase_descriptor circular dependency Remove the plugs to phase_descriptor circular dependency by moving the pieces phase_descriptor depends on to a new core/base_plugs.py file. PiperOrigin-RevId: 332527874 * PhaseDescriptor: with_plugs and with_args now ignore unknowns Change with_plugs and with_args to use their with_known_plugs and with_known_args implementations instead. PiperOrigin-RevId: 332546916 * Add type checking to unit tests to verify things are working. PiperOrigin-RevId: 332551203 * test_descriptor: Remove Test Teardown. Test teardown was deprecated in favor of PhaseGroup teardowns. Fully removing them. PiperOrigin-RevId: 333112589 * Add PhaseNode and implement PhaseSequence. Phase nodes are now the basic building block of the OpenHTF execution engine. Phase sequence is a phase node that constains a sequence of phase nodes. Phase groups now use phase sequences to contain its setup, main, and teardown phases. PiperOrigin-RevId: 334461205 * Implement Phase Branches Phase branches run phases conditionally based on triggered diagnosis results. PiperOrigin-RevId: 335460872 * PhaseExecutor: Raise on invalid phase result. PiperOrigin-RevId: 335469722 * Implement Subtests. Subtests are a collection of phases that can indepenently fail and skip the rest of the phases while still working with PhaseGroup teardowns. PiperOrigin-RevId: 335472411 * util/test: Allow customizing the test_start_function. The OpenHTF TestCase can now customize the test start function by setting the `test_start_function` attribute. This change will now force unit tests to call super().setUp() in all cases. PiperOrigin-RevId: 335509542 * Implement Phase Checkpoints Phase checkpoints are nodes that check if a diagnosis result has been triggered or a simple set of phases has failed. In those cases, they will either be resolved as FAIL_SUBTEST or STOP. PiperOrigin-RevId: 335513243 * Refactor TestApi and expose diagnoses store. The TestApi object should just be a proxy to the functions on the PhaseState and TestState instances. Add the diagnoses store to the API for simpler access during phases. PiperOrigin-RevId: 336213159 * Subtest skip phases when they fail. Subtests should skip the later phases with special handling for other nodes as documented in event_sequence.md. PiperOrigin-RevId: 336386553 * Fix typo in TestApi.diagnoses_store PiperOrigin-RevId: 336408351 * Internal change PiperOrigin-RevId: 336691169 * Add DimensionPivot. DimensionPivot is a validator that runs a subvalidator on each value independently for a dimensioned measurement. If any value fails, the measurement is a failure. PiperOrigin-RevId: 336730422 * Drop PY2 support from OpenHTF. PiperOrigin-RevId: 337139629
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to have been accidentally removed in #960
This change is