dashboard/app: fix parsing bug and accept "gs://" prefixes #5633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarasmadan
force-pushed
the
skip_prefix
branch
from
b0b96ef to
7ee3512
Compare
tarasmadan
changed the title
tarasmadan
force-pushed
the
skip_prefix
branch
from
7ee3512 to
ee6efd1
Compare
Bug: payload is a serialized json, not string.
tarasmadan
force-pushed
the
skip_prefix
branch
from
ee6efd1 to
ca9871a
Compare
ramosian-glider
approved these changes
Dec 20, 2024
|
We mock the whole dashapi communication to test clients. It makes sense to check codecov coverage.... |
|
#5634 to test the first, trivial one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.