Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated description in translations and feed_info #412

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Updated description in translations and feed_info #412

merged 1 commit into from
Dec 15, 2023

Conversation

ponlawat-w
Copy link
Contributor

Should this paragraph which appeared in feed_info description belong to translations instead?

If both referencing methods (record_id, record_sub_id) and field_value are used to translate the same value in 2 different rows, the translation provided with (record_id, record_sub_id) takes precedence.

@tzujenchanmbd
Copy link
Collaborator

Thanks for catching this @ponlawat-w !

Yes, this seems like it should appear in translation rather than feed_info.

Since this is just an editorial correction without impacting any semantics, I propose that we don’t need to go through the voting process. If there are no other opinions, we can proceed to merge directly in a few days.

@tzujenchanmbd tzujenchanmbd self-requested a review December 7, 2023 18:25
leonardehrenfried
leonardehrenfried approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@leonardehrenfried leonardehrenfried left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Tzu-Chen.

@tzujenchanmbd tzujenchanmbd merged commit b776305 into google:master Dec 15, 2023
2 checks passed
@isabelle-dr isabelle-dr added Change: Clarification Revisions of the current specification to improve understanding. GTFS Schedule Issues and Pull Requests that focus on GTFS Schedule Change: Editorial Inconsequential changes to the specification such as link updates, grammatical errors, formatting. and removed Change: Clarification Revisions of the current specification to improve understanding. labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzujenchanmbd tzujenchanmbd tzujenchanmbd approved these changes

@leonardehrenfried leonardehrenfried leonardehrenfried approved these changes

Assignees
No one assigned
Labels
Change: Editorial Inconsequential changes to the specification such as link updates, grammatical errors, formatting. GTFS Schedule Issues and Pull Requests that focus on GTFS Schedule
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ponlawat-w @tzujenchanmbd @leonardehrenfried @isabelle-dr