Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding wasm/threads submodule. #475

Merged
merged 7 commits into from
May 17, 2024
Merged

Adding wasm/threads submodule. #475

merged 7 commits into from
May 17, 2024

Conversation

resulknad
Copy link
Collaborator

Moving from #466 into its own PR. #423

@resulknad resulknad requested a review from ia0 as a code owner May 17, 2024 18:55
@ia0 ia0 changed the base branch from main to dev/wasm-threads May 17, 2024 20:06
@ia0 ia0 changed the base branch from dev/wasm-threads to main May 17, 2024 20:09
@ia0 ia0 changed the base branch from main to dev/wasm-threads May 17, 2024 20:09
ia0
ia0 previously approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@ia0 ia0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

The sort behavior was intended (i.e. using ASCII order), but I guess you have a different LC_COLLATE. I made the script more robust.

@ia0 ia0 removed the dependencies label May 17, 2024
@ia0 ia0 merged commit f346a61 into google:dev/wasm-threads May 17, 2024
19 checks passed
resulknad added a commit to resulknad/wasefire that referenced this pull request May 18, 2024
@resulknad @ia0
Add WebAssembly/threads submodule (google#475)
706b6b2 
Co-authored-by: Julien Cretin <[email protected]>
resulknad added a commit to resulknad/wasefire that referenced this pull request May 18, 2024
@resulknad @ia0
Add WebAssembly/threads submodule (google#475)
4d12cf0 
Co-authored-by: Julien Cretin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ia0 ia0 ia0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@resulknad @ia0