-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Naive glyphname => IR filename leads to glyphs overwritten on case insensitive filesystems #41
Comments
I just re-stumbled on this while running fontc on a Mac. It happens with any font that has both uppercase and lowercase glyphs e.g. "A" and "a" as in the following test file: Aa.glyphs.zip running This makes using the default --emit-ir=true very risky when running fontc on a non-Linux. |
Maybe incremental build should be opt-in rather then opt out, and --emit-ir=false by default. |
I've previously suggested some ideas to enhance the UFO glyph name -> file name scheme, but today I would be inclined to just append a hash of the glyph name to the file name. Regardless of incremental build issues, this seems a problem worth fixing. |
How are case insensitive filesystems still a thing!
It's quite handy to have a human readable name when troubleshooting. Let's
implement a scheme to make it work.
|
Thanks Just. I had linked to that other thread, contains useful hints but got sidetracked.
but hash cannot be reverted, can it? Ideally we'd be able to go in either direction with only the glyph name or the filename available. I still like the idea of keeping the conventional |
#487 and friends are resolved, afaics we're done here. |
right now we use {glyph_name}.yml but that only works on case sensitive fs like Linux.
Initially I thought I'd use norad's
user_name_to_file_name
method (which uses UFO filenaming conventions) for this, but it actually complicates things because we need to know all glyph names upfront and it's order dependent (we can't call that on demand because its output depends on the order in which duplicate clashes are handled).we could try see if we can use a scheme like Just proposed in unified-font-object/ufo-spec#164, which has an added bonus of being reversible
The text was updated successfully, but these errors were encountered: