Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an underscore after capitals in glyph names #486

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Add an underscore after capitals in glyph names #486

merged 1 commit into from
Oct 9, 2023

Conversation

rsheeter
Copy link
Contributor

@rsheeter rsheeter commented Oct 9, 2023 •
edited
Loading

Helps with #41. Doesn't deal with reserved / weird filenames.

anthrotype
anthrotype reviewed Oct 9, 2023
View reviewed changes
fontdrasil/src/paths.rs Outdated Show resolved Hide resolved
anthrotype
anthrotype approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@anthrotype anthrotype left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once test pass

this might be ok for a first pass, but the illegal characters and reserved filename will surely come back biting us at some point

@rsheeter
Copy link
Contributor Author

rsheeter commented Oct 9, 2023

illegal characters and reserved filename will surely come back biting us at some point

Yup! Baby steps :)

@rsheeter rsheeter added this pull request to the merge queue Oct 9, 2023
Merged via the queue into main with commit ca5862c Oct 9, 2023
8 checks passed
@rsheeter rsheeter deleted the case branch October 9, 2023 16:01
@rsheeter rsheeter mentioned this pull request Oct 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthrotype anthrotype anthrotype approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rsheeter @anthrotype