minor: fix ResourceWarning about unclosed file descriptor

googlefonts · Dec 3, 2021 · e71c031 · e71c031
1 parent e80c09b
commit e71c031
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/Lib/glyphsLib/glyphdata.py b/Lib/glyphsLib/glyphdata.py
@@ -105,10 +105,9 @@ def get_glyph(glyph_name, data=None, unicodes=None):
         if GLYPHDATA is None:
             from importlib.resources import open_binary
 
-            GLYPHDATA = GlyphData.from_files(
-                open_binary("glyphsLib.data", "GlyphData.xml"),
-                open_binary("glyphsLib.data", "GlyphData_Ideographs.xml"),
-            )
+            with open_binary("glyphsLib.data", "GlyphData.xml") as f1:
+                with open_binary("glyphsLib.data", "GlyphData_Ideographs.xml") as f2:
+                    GLYPHDATA = GlyphData.from_files(f1, f2)
         data = GLYPHDATA
 
     # Look up data by full glyph name first.