Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename florin to fhook #1032

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

moyogo
Copy link
Collaborator

@moyogo moyogo commented Sep 28, 2024

Change caterogy=Letter, case=lower as in Unicode.

Keep production name as florin for AGL.

Change caterogy=Letter, case=lower as in Unicode.

Keep production nam as florin for AGL.
@moyogo
Copy link
Collaborator Author

moyogo commented Sep 29, 2024

The test_glyphs_to_designspace[AndadaPro.glyphs] regression test fails because of fhook.sc having the production name florin.sc in the generated UFOs with this PR’s change, when it had none previously.

AndadaPro.glyphs has a messy setup with regard to Fhook/fhook.
Fhook is as expected, florin is a letter (upright, ascender to descender height), fhook.sc is a smallcap Fhook, florin.sc is a currency symbol (italic, short).
The c2sc feature has the incorrect sub Fhook by florin.sc when it should be sub Fhook by fhook.sc.
The smcp feature does not have any substitution sub florin by fhook.sc.

Glyphs.app 3.3 (3322) doesn’t generate the adequate substitutions automatically if upper and lower case are not named Fhook and fhook.

When florin is renamed fhook, the adequate sub Fhook by fhook.sc and sub fhook by fhook.sc are added to c2sc and smcp respectively sub Fhook by fhook.sc is still not added to c2sc but the same sub ad smcp’s sub fhook by fhook.sc is added.

/cc @schriftgestalt

@anthrotype
Copy link
Member

shouldn't any changes to the data xml files first be applied to the upstream repository and then sync'ed back in here? (if that's already the case, ignore me and just merge)

@anthrotype
Copy link
Member

oh I now see you also filed schriftgestalt/GlyphsInfo#41. let's merge once that one is also merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants