Skip to content
This repository has been archived by the owner on Mar 9, 2021. It is now read-only.

[GOVCMSD8-282] Exclude node_modules from "ahoy lint" #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gargsuchi
Copy link

This PR does the following:

  • Adds a lint-theme script to the code base - which excludes the path {PROFILE_DIR}/themes/custom/*/node_modules
  • Adds phpcs.xml to the codebase
  • Updates the Dockerfile.test to copy the above to the container
  • Makes the lint-theme executable in the container

@tobybellwood
Copy link

Ah nice - so after this, we can remove the lint-theme steps from govcms/govcms8 and instead only have them here - given we don't expect a theme to be present at either govcms8 or govcms8lagoon. As I understand, it will just overwrite the existing file whilst it still exists.

@gargsuchi
Copy link
Author

@tobybellwood That's correct.

@simesy
Copy link
Contributor

simesy commented Dec 20, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants