Allow Symfony 7 #89
Allow Symfony 7 #89
Conversation
|
Tests fail. Please see what the problem might be. |
Tests are failing on code coverage upload. I'm afraid it might be out of my reach to fix that, possibly something on the other side? It fails only for one case where I've changed PHP and Sf version to supported one (Sf 6.0->6.4 and PHP 8.0->8.1 per Sf requirements and new PHP 8.2 + Sf 7). But I'll fix the CS for sure (errors are out of my changes, but that's trivial to fix anyways, so no problem). |
|
@peter-gribanov I think I have fixed both code style and CI workflow so that it can pass, but the checks needs approval to be sure 👍 |
|
I have ran them elsewhere only to find phpstan having some troubles. Sorry for the noise, I will investigate further... |
Lustmored
force-pushed
the
symfony-7
branch
3 times, most recently
from
f0b54c0 to
ff3acae
Compare
|
@peter-gribanov I think I have won with phpstan. I cannot test code coverage upload, so please accept actions to see. I had to bump both phpstan and PHP minimal version (the latter is required by phpstan) and adapt to changes within. How do you feel about dropping support for unmaintained PHP and/or Symfony versions? I can step up and create a PR with such work if that sounds good to you (or maybe even go for it in this one?) |
|
Good job. Thank you 👍 |
|
I made a new release Releases 2.1.0 |
This is a simple PR allowing Symfony 7 components to be used with this bundle.