Set OTel metrics telemetry level to "detailed". #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I opened #792 for this to be made more configurable. |
|
I tested this change locally using the config file in our docs. I see two extra batch processor metrics than what I saw with v1.0.0, but all those metrics have been around for a while and I think I can assume that they must have been in v1.0.0. This is why I'm not adding the metrics which I'm documenting now to the changelog. I'm not sure why I don't see them locally though. |
rfratto
added
backport-to-agent
github-actions bot
pushed a commit
that referenced
this pull request
May 8, 2024
(cherry picked from commit bcb1d29)
ptodev
added a commit
that referenced
this pull request
May 8, 2024
(cherry picked from commit bcb1d29) Co-authored-by: Paulin Todev <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
In OTel collector v0.99.0, there was a change to how metrics are displayed.
Since Alloy v1.0.0 shows all grpc-level metrics, we need to use the "detailed" logging level by default for backwards compatibility.
Which issue(s) this PR fixes
Fixes #776
PR Checklist