column selector fix for variables editor

grafana · May 20, 2024 · 5e0a5b7 · 5e0a5b7
1 parent 55c5709
commit 5e0a5b7
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 8 deletions.
diff --git a/.changeset/lucky-starfishes-attend.md b/.changeset/lucky-starfishes-attend.md
@@ -0,0 +1,5 @@
+---
+'grafana-infinity-datasource': patch
+---
+
+Fixed a bug where column selectors weren't working in variables editor
diff --git a/src/components/QueryColumnItem.tsx b/src/components/QueryColumnItem.tsx
@@ -19,23 +19,27 @@ export const QueryColumnItem = (props: QueryColumnItemProps) => {
     return <></>;
   }
   const onSelectorChange = () => {
-    let columns = [...(query.columns || [])];
-    columns[index].selector = selector;
+    const columns = [...query.columns];
+    let newItem = { ...columns[index], selector };
+    columns[index] = newItem;
     onChange({ ...query, columns });
   };
   const onTextChange = () => {
-    let columns = [...(query.columns || [])];
-    columns[index].text = text;
+    const columns = [...query.columns];
+    let newItem = { ...columns[index], text };
+    columns[index] = newItem;
     onChange({ ...query, columns });
   };
   const onTimeFormatChange = (timestampFormat: string) => {
-    let columns = [...(query.columns || [])];
-    columns[index].timestampFormat = timestampFormat;
+    const columns = [...query.columns];
+    let newItem = { ...columns[index], timestampFormat };
+    columns[index] = newItem;
     onChange({ ...query, columns });
   };
   const onFormatChange = (type: InfinityColumnFormat) => {
-    let columns = [...(query.columns || [])];
-    columns[index].type = type;
+    const columns = [...query.columns];
+    let newItem = { ...columns[index], type };
+    columns[index] = newItem;
     onChange({ ...query, columns });
   };
   return (