Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

managed datasource instance migration #876

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Conversation

yesoreyeram
Copy link
Collaborator

backend datasource.serve method migrated to datasource.manage method.

How to test

  • build the frontend yarn build
  • build the backend mage -v
  • spin up the grafana docker compose up
  • visit localhost:3000
  • open the provisioned datasource Postman Echo - Basic Auth and perform the health check -This ensure check health code path works as expected
  • open the provisioned datasource Infinity - Open the explore and run query.
  • change to backend parser - should produce the results
  • change the source to "reference data" and select "users.csv", change the type to "csv" - should produce the results. This ensure the resource calls and query path works as expected.

@yesoreyeram yesoreyeram requested a review from a team as a code owner June 12, 2024 11:20
Copy link
Member

@gwdawson gwdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left one comment but otherwise LGTM!

pkg/infinity/postprocess.go Show resolved Hide resolved
@yesoreyeram yesoreyeram merged commit cb91e3d into main Jun 14, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants