Chore: Update default log level Debug->Info
#1794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Baarsgaard
requested review from
NissesSenap,
weisdd,
ishanjainn,
theSuess,
hubeadmin and
pb82
as code owners
|
Can we still keep the |
Due to using production mode, the default encoder changed to json
Baarsgaard
force-pushed
the
update_default_log_level
branch
from
6b27219 to
2c4d213
Compare
|
@theSuess figured it out. |
theSuess
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switching to production mode has the side-effect that the default encoder also changed to
jsonEncoderIt might make sense to keep the
consoleEncoder, henceDevelopment modeis explicitly enabled in the makefile.Should I also create an overlay or similar configuration for the
make deploytarget which enablesDevelopment modefor outputting debug logs?In case we start using them.