fix: add 'webex' as valid type for GrafanaContactPoints (#1798)

[FabianWilms]

related issue: #1798

[CLAassistant]

All committers have signed the CLA.

[weisdd]

Thanks for the PR!

Please, take a look at PR validation errors to see what's missing in the PR.

[FabianWilms]

Please, take a look at PR validation errors to see what's missing in the PR.

It seems like the 'only' thing missing according to the checks (and the contribution guidelines 😅 ) is running make test.

As I don't have the required permissions to install all tools needed for this on my work machine I tried to do so on my private one - sadly this only has windows installed.

I tried to install everything needed to get the makefile to work, but sadly am still running into errors.

fabia@Wilms-NB MINGW64 ~/develop/grafana-operator (master)
$ make test
process_begin: CreateProcess(NULL, kind get clusters, ...) failed.
mkdir -p /c/Users/fabia/develop/grafana-operator/bin
test -s /c/Users/fabia/develop/grafana-operator/bin/controller-gen || GOBIN=/c/Users/fabia/develop/grafana-operator/bin go install sigs.k8s.io/controller-tools/cmd/[email protected]
test -s /c/Users/fabia/develop/grafana-operator/bin/kustomize || { curl -Ss "https://raw.githubusercontent.com/kubernetes-sigs/kustomize/master/hack/install_kustomize.sh" | bash -s -- 5.1.1 /c/Users/fabia/develop/grafana-operator/bin; }
/c/Users/fabia/develop/grafana-operator/bin/controller-gen rbac:roleName=manager-role webhook paths="./..." crd output:crd:artifacts:config=config/crd/bases
/c/Users/fabia/develop/grafana-operator/bin/controller-gen rbac:roleName=manager-role webhook paths="./..." crd output:crd:artifacts:config=deploy/helm/grafana-operator/crds
/c/Users/fabia/develop/grafana-operator/bin/yq -i '(select(.kind == "Deployment") | .spec.template.spec.containers[0].env[] | select (.name == "RELATED_IMAGE_GRAFANA")).value="docker.io/grafana/grafana:11.3.0"' config/manager/manager.yaml
process_begin: CreateProcess(NULL, /c/Users/fabia/develop/grafana-operator/bin/yq -i "(select(.kind == \"Deployment\") | .spec.template.spec.containers[0].env[] | select (.name == \"RELATED_IMAGE_GRAFANA\")).value=\"docker.io/grafana/grafana:11.3.0\"" config/manager/manager.yaml, ...) failed.
make (e=2): Das System kann die angegebene Datei nicht finden.
make: *** [manifests] Fehler 2

Would you mind running the make test on my fork? You should have access to it.

[weisdd]

@FabianWilms sure, I'll take care of that.

Btw, our Makefile might work on WSL2, not sure if anyone has already tried it out there though.

[FabianWilms]

sure, I'll take care of that.

Thank you very much!

Btw, our Makefile might work on WSL2, not sure if anyone has already tried it out there though.

It actually does! Sadly got it to run too late, but for the next PR I'm prepared!