refactor: Avoid param reassignment in group_snippet #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
going-confetti
requested review from
cristianoventura,
e-fisher and
Llandy3d
and removed request for
a team
going-confetti
commented
Nov 8, 2024
Comment on lines
+51
to
+53
| const updatedParams = Object.assign({}, params, { | ||
| headers: Object.assign({}, params.headers || {}, groupHeaders), | ||
| }) |
There was a problem hiding this comment.
TIL that our version of k6 doesn't support the spread operator. It was added to a newer version (grafana/k6#3456)
There was a problem hiding this comment.
I'm not quite happy with this snippet "polluting" the global namespace, essentially making it impossible to create user-defined variables with names like Client, trimAndRemovePrefix, etc - it's only possible in custom code snippets (and I'm still not sure whether those should have their own scope - let's have a separate discussion on that)
There was a problem hiding this comment.
good point!
We should definitely not reserve those names 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How to Test
Checklist
Screenshots (if appropriate):
Related PR(s)/Issue(s)