Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update examples to use TLA #4040

Merged
merged 1 commit into from
Nov 7, 2024
Merged

chore: update examples to use TLA #4040

merged 1 commit into from
Nov 7, 2024

Conversation

mstoykov
Copy link
Contributor

@mstoykov mstoykov commented Nov 7, 2024

What?

Update examples to use TLA instead of the workaround

Why?

Better examples

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

#4007

@mstoykov mstoykov added this to the v0.55.0 milestone Nov 7, 2024
@mstoykov mstoykov requested a review from a team as a code owner November 7, 2024 13:47
@mstoykov mstoykov requested review from inancgumus and ankur22 and removed request for a team November 7, 2024 13:47
inancgumus
inancgumus approved these changes Nov 7, 2024
View reviewed changes
Copy link
Member

@inancgumus inancgumus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't see any issues. LGTM.

ankur22
ankur22 approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@ankur22 ankur22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@mstoykov mstoykov merged commit a40d853 into master Nov 7, 2024
22 checks passed
@mstoykov mstoykov deleted the updateExamples branch November 7, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankur22 ankur22 ankur22 approved these changes

@inancgumus inancgumus inancgumus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.55.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mstoykov @inancgumus @ankur22