Rule Concurrency: Prevent flapping of concurrency #10189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
gotjosh
reviewed
Dec 9, 2024
There was a problem hiding this comment.
This looks good given it fixes the immediately problem -- However, I'd prefer if we have 2 fields for the runtime - one without concurrency and one with concurrency that we'd only update once the group finishes evaluating.
I think this will make the runtimes more deterministic and it'll also help us see the difference between expected runtime vs actual runtime (if we expose it as a metric).
The complex part is that we need to do that in Prometheus.
|
We also discussed offline, and we're going to implement this change directly in Prometheus. We agreed that we should two things:
|
julienduchesne
force-pushed
the
julienduchesne/concurrency-no-flapping
branch
from
3c5ae76 to
7b03ca1
Compare
|
Can you please add a changelog entry and make sure you map the newly introduced metric in https://github.com/grafana/mimir/blob/main/pkg/ruler/manager_metrics.go? |
julienduchesne
force-pushed
the
julienduchesne/concurrency-no-flapping
branch
from
636224f to
4253538
Compare
Done! |
gotjosh
approved these changes
Dec 13, 2024
julienduchesne
force-pushed
the
julienduchesne/concurrency-no-flapping
branch
from
5a418ba to
f76a168
Compare
tacole02
reviewed
Dec 16, 2024
Iterates on #8146 The `isGroupAtRisk` function only uses the group's last evaluation time as a metric However, if the concurrency of the group causes the group's eval time to lower to less than the threshold, this will flap between enabling concurrency and disabling it on every run In this PR, a condition is added to also sum up the last evaluation time of each rule to compare against the threshold
Co-authored-by: gotjosh <[email protected]>
julienduchesne
force-pushed
the
julienduchesne/concurrency-no-flapping
branch
from
f76a168 to
1228428
Compare
julienduchesne
added a commit
that referenced
this pull request
Dec 17, 2024
* Rule Concurrency: Prevent flapping of concurrency Iterates on #8146 The `isGroupAtRisk` function only uses the group's last evaluation time as a metric However, if the concurrency of the group causes the group's eval time to lower to less than the threshold, this will flap between enabling concurrency and disabling it on every run In this PR, a condition is added to also sum up the last evaluation time of each rule to compare against the threshold * Linting * Use the new `evaluationRuleTimeSum` field from the group * Linting * Add changelog + metric * Apply suggestions from code review Co-authored-by: gotjosh <[email protected]> * Unrevert crypto * Fix typo in changelog --------- Co-authored-by: gotjosh <[email protected]>
julienduchesne
added a commit
that referenced
this pull request
Dec 17, 2024
* Rule Concurrency: Prevent flapping of concurrency Iterates on #8146 The `isGroupAtRisk` function only uses the group's last evaluation time as a metric However, if the concurrency of the group causes the group's eval time to lower to less than the threshold, this will flap between enabling concurrency and disabling it on every run In this PR, a condition is added to also sum up the last evaluation time of each rule to compare against the threshold * Linting * Use the new `evaluationRuleTimeSum` field from the group * Linting * Add changelog + metric * Apply suggestions from code review Co-authored-by: gotjosh <[email protected]> * Unrevert crypto * Fix typo in changelog --------- Co-authored-by: gotjosh <[email protected]>
4 tasks
julienduchesne
added a commit
that referenced
this pull request
Dec 17, 2024
* Update mimir-prometheus weekly-r321 This includes: - grafana/mimir-prometheus#807 - grafana/mimir-prometheus#806 Signed-off-by: Oleg Zaytsev <[email protected]> * Rule Concurrency: Prevent flapping of concurrency (#10189) * Rule Concurrency: Prevent flapping of concurrency Iterates on #8146 The `isGroupAtRisk` function only uses the group's last evaluation time as a metric However, if the concurrency of the group causes the group's eval time to lower to less than the threshold, this will flap between enabling concurrency and disabling it on every run In this PR, a condition is added to also sum up the last evaluation time of each rule to compare against the threshold * Linting * Use the new `evaluationRuleTimeSum` field from the group * Linting * Add changelog + metric * Apply suggestions from code review Co-authored-by: gotjosh <[email protected]> * Unrevert crypto * Fix typo in changelog --------- Co-authored-by: gotjosh <[email protected]> --------- Signed-off-by: Oleg Zaytsev <[email protected]> Co-authored-by: Julien Duchesne <[email protected]> Co-authored-by: gotjosh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Iterates on #8146
The
isGroupAtRiskfunction only uses the group's last evaluation time as a metricHowever, if the concurrency of the group causes the group's eval time to lower to less than the threshold, this will flap between enabling concurrency and disabling it on every run
In this PR, a condition is added to also sum up the last evaluation time of each rule to compare against the threshold
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.