Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update github.com/thanos-io/objstore digest to 925be82 (main) #10244

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Dec 16, 2024

This PR contains the following updates:

Package Type Update Change
github.com/thanos-io/objstore require digest 8d266b9 -> 925be82

Configuration

📅 Schedule: Branch creation - "before 9am on Monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot requested review from stevesg, grafanabot and a team as code owners December 16, 2024 04:16
Copy link
Contributor

@aknuds1 aknuds1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change in objstore is kind of bad, since it changes the semantics of WithExpectedErrs to also mean that errors are not returned.

@aknuds1
Copy link
Contributor

aknuds1 commented Dec 16, 2024

I've asked for the PR to be reverted. I mainly think the method now violates the principle of least surprise.

@aknuds1
Copy link
Contributor

aknuds1 commented Dec 16, 2024

I've made a PR to revert the thanos-io/objstore change.

@renovate renovate bot changed the title Update github.com/thanos-io/objstore digest to d69df72 (main) fix(deps): update github.com/thanos-io/objstore digest to d69df72 (main) Dec 16, 2024
@renovate renovate bot changed the title fix(deps): update github.com/thanos-io/objstore digest to d69df72 (main) Update github.com/thanos-io/objstore digest to d69df72 (main) Dec 16, 2024
@renovate renovate bot changed the title Update github.com/thanos-io/objstore digest to d69df72 (main) fix(deps): update github.com/thanos-io/objstore digest to d69df72 (main) Dec 16, 2024
@renovate renovate bot changed the title fix(deps): update github.com/thanos-io/objstore digest to d69df72 (main) Update github.com/thanos-io/objstore digest to d69df72 (main) Dec 16, 2024
@renovate renovate bot changed the title Update github.com/thanos-io/objstore digest to d69df72 (main) Update github.com/thanos-io/objstore digest to 925be82 (main) Dec 16, 2024
@renovate renovate bot force-pushed the deps-update/main-github.com-thanos-io-objstore-digest branch from 161b2ec to 0b5bf99 Compare December 16, 2024 21:09
Copy link
Contributor

@aknuds1 aknuds1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, as the change in question was reverted.

@aknuds1 aknuds1 merged commit 57f6c16 into main Dec 17, 2024
29 checks passed
@aknuds1 aknuds1 deleted the deps-update/main-github.com-thanos-io-objstore-digest branch December 17, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant