Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mimir-prometheus to latest version #10258

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

julienduchesne
Copy link
Member

@julienduchesne julienduchesne commented Dec 16, 2024

It was synced here: grafana/mimir-prometheus#792

Fixed failing tests

  • TestCardinalityQueryRequestValidationRoundTripper: revert model.NameValidationScheme to LegacyValidation in the query frontend. The same way that it is done for the distributor:
    model.NameValidationScheme = model.LegacyValidation
  • TestStreamingChunkSeries_CreateIteratorTwice: Quote label name in error message
  • TestOurUpstreamTestCasesAreInSyncWithUpstream: Sync upstream test cases

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

@julienduchesne julienduchesne marked this pull request as ready for review December 16, 2024 16:12
It was synced here: grafana/mimir-prometheus#792

Fixed failing tests
- `TestCardinalityQueryRequestValidationRoundTripper`: revert `model.NameValidationScheme` to `LegacyValidation`
- `TestStreamingChunkSeries_CreateIteratorTwice`: Quote label name in error message
- `TestOurUpstreamTestCasesAreInSyncWithUpstream`: Sync upstream test cases
@julienduchesne julienduchesne force-pushed the julienduchesne/update-mimir-prometheus branch from 8c7f184 to e32bf81 Compare December 16, 2024 17:23
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@dimitarvdimitrov dimitarvdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the Mimir changes SGTM. I didn't review the prometheus/prometheus changes

Copy link
Contributor

@gotjosh gotjosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Dimitar Dimitrov <[email protected]>
@julienduchesne julienduchesne merged commit 97d684e into main Dec 17, 2024
29 checks passed
@julienduchesne julienduchesne deleted the julienduchesne/update-mimir-prometheus branch December 17, 2024 13:55
julienduchesne added a commit that referenced this pull request Dec 17, 2024
* Update `mimir-prometheus` to latest version
It was synced here: grafana/mimir-prometheus#792

Fixed failing tests
- `TestCardinalityQueryRequestValidationRoundTripper`: revert `model.NameValidationScheme` to `LegacyValidation`
- `TestStreamingChunkSeries_CreateIteratorTwice`: Quote label name in error message
- `TestOurUpstreamTestCasesAreInSyncWithUpstream`: Sync upstream test cases

* Update CHANGELOG.md

Co-authored-by: Dimitar Dimitrov <[email protected]>

---------

Co-authored-by: Dimitar Dimitrov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants