Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimir-build-image: Explicitly set GOTOOLCHAIN=local #9082

Merged
merged 3 commits into from
Aug 23, 2024

Conversation

aknuds1
Copy link
Contributor

@aknuds1 aknuds1 commented Aug 23, 2024

What this PR does

In mimir-build-image/Dockerfile, explicitly override environment variable GOTOOLCHAIN to be local, to make sure that the Docker image's bundled Go toolchain is used, rather than the one specified via the toolchain directive in go.mod. The same is already done in official Go images, but being explicit helps also to document.

Which issue(s) this PR fixes or relates to

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

@aknuds1 aknuds1 requested a review from pstibrany August 23, 2024 10:01
@aknuds1 aknuds1 requested a review from a team as a code owner August 23, 2024 10:01
Copy link
Contributor

Building new version of mimir-build-image. After image is built and pushed to Docker Hub, a new commit will automatically be added to this PR with new image version grafana/mimir-build-image:pr9082-9cdfcfb710. This can take up to 1 hour.

@aknuds1 aknuds1 force-pushed the arve/override-go-toolchain branch from b36c1f8 to 17cd5cf Compare August 23, 2024 10:04
Copy link
Member

@pstibrany pstibrany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @aknuds1! This cleans up confusion about which toolchain is used in our builds.

@aknuds1 aknuds1 force-pushed the arve/override-go-toolchain branch from 17cd5cf to ca6c52b Compare August 23, 2024 10:06
Copy link
Contributor

Building new version of mimir-build-image. After image is built and pushed to Docker Hub, a new commit will automatically be added to this PR with new image version grafana/mimir-build-image:pr9082-9cdfcfb710. This can take up to 1 hour.

mimir-build-image/Dockerfile Outdated Show resolved Hide resolved
Co-authored-by: Vladimir Varankin <[email protected]>
@aknuds1 aknuds1 requested a review from narqo August 23, 2024 10:38
Copy link
Contributor

Building new version of mimir-build-image. After image is built and pushed to Docker Hub, a new commit will automatically be added to this PR with new image version grafana/mimir-build-image:pr9082-d0a22a8a96. This can take up to 1 hour.

@aknuds1 aknuds1 force-pushed the arve/override-go-toolchain branch from a319d46 to e1083e9 Compare August 23, 2024 11:26
@aknuds1 aknuds1 enabled auto-merge (squash) August 23, 2024 11:27
Copy link
Contributor

Not building new version of mimir-build-image. This PR modifies mimir-build-image/Dockerfile, but the image grafana/mimir-build-image:pr9082-d0a22a8a96 already exists.

@aknuds1 aknuds1 merged commit 1dc7a07 into main Aug 23, 2024
30 checks passed
@aknuds1 aknuds1 deleted the arve/override-go-toolchain branch August 23, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants