-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mimir-build-image: Explicitly set GOTOOLCHAIN=local #9082
Conversation
Building new version of mimir-build-image. After image is built and pushed to Docker Hub, a new commit will automatically be added to this PR with new image version |
b36c1f8
to
17cd5cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much @aknuds1! This cleans up confusion about which toolchain is used in our builds.
Signed-off-by: Arve Knudsen <[email protected]>
17cd5cf
to
ca6c52b
Compare
Building new version of mimir-build-image. After image is built and pushed to Docker Hub, a new commit will automatically be added to this PR with new image version |
Co-authored-by: Vladimir Varankin <[email protected]>
Building new version of mimir-build-image. After image is built and pushed to Docker Hub, a new commit will automatically be added to this PR with new image version |
Signed-off-by: Arve Knudsen <[email protected]>
a319d46
to
e1083e9
Compare
Not building new version of mimir-build-image. This PR modifies |
What this PR does
In mimir-build-image/Dockerfile, explicitly override environment variable
GOTOOLCHAIN
to belocal
, to make sure that the Docker image's bundled Go toolchain is used, rather than the one specified via thetoolchain
directive in go.mod. The same is already done in official Go images, but being explicit helps also to document.Which issue(s) this PR fixes or relates to
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]
.about-versioning.md
updated with experimental features.