makefile: Run mixtool in container
#9117
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also updates mixtool to latest version which closes #1617 Mixtool was actually updated two months ago, so the dashboards are already all compliant! For the Makefile changes, I was looking at the issue above and I wanted to test it using the build image. I noticed that it wasn't actually running in the container. This should make it easier to test in the future.
julienduchesne
changed the title
mixtool in containermixtool in container
|
Building new version of mimir-build-image. After image is built and pushed to Docker Hub, a new commit will automatically be added to this PR with new image version |
julienduchesne
requested review from
wilfriedroset,
vaxvms,
bubu11e and
a team
as code owners
pracucci
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also updates mixtool to latest version which closes #1617
Mixtool was actually updated two months ago, so the dashboards are already all compliant!
Makefile changes:
I was looking at the issue above and I wanted to test it using the build image. I noticed that it wasn't actually running in the container. This makes the
check-mixin-*steps run in the build image for local uses and should make it easier to test in the future.