query-tee: Add an option to skip samples for comparison before a given timestamp #9515
Conversation
…n timestamp Signed-off-by: Ganesh Vernekar <[email protected]>
Signed-off-by: Ganesh Vernekar <[email protected]>
codesome
force-pushed
the
codesome/tee-skip-old
branch
2 times, most recently
from
cb78eb1 to
3e21051
Compare
Signed-off-by: Ganesh Vernekar <[email protected]>
codesome
force-pushed
the
codesome/tee-skip-old
branch
from
3e21051 to
003c2cf
Compare
Signed-off-by: Ganesh Vernekar <[email protected]>
Signed-off-by: Ganesh Vernekar <[email protected]>
|
@charleskorn I improved the error message a little bit (unit tests should also reflect that) and also added a comment about it when we filter the samples in the vector. |
Signed-off-by: Ganesh Vernekar <[email protected]>
Signed-off-by: Ganesh Vernekar <[email protected]>
|
Should be all good now! |
Signed-off-by: Ganesh Vernekar <[email protected]>
There was a problem hiding this comment.
LGTM. I left few minor comments I would be glad if you could take a look at.
I think there a case where comparison will still fail. The compareMatrix() checks len(expected) != len(actual) as first thing. This means that if the number of series is different, it will just fail. However, the number of series may be different just because one of the series has all samples before SkipSamplesBefore and so it's not returned by one of the 2 backends you're comparing.
I don't think it's worth blocking this PR merging (you can already get some value with these changes), but I've the feeling you will have to re-iterate on this.
Co-authored-by: Marco Pracucci <[email protected]>
Co-authored-by: Marco Pracucci <[email protected]>
Signed-off-by: Ganesh Vernekar <[email protected]>
… codesome/tee-skip-old Signed-off-by: Ganesh Vernekar <[email protected]>
|
Follow up of this PR is here #9660 |
What this PR does
Similar to how we have
-proxy.compare-skip-recent-samples, this PR adds-proxy.compare-skip-samples-beforeto skip samples for comparison that are before the given unix timestamp. It is useful for block builders where you don't want to compare beyond a certain point.Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.