Refactor TraceNavigation

Based on discussions in #1140 , a decision was made to, instead of using
the URL as the span name for navigation spans, use the word 'navigation'
to identify the action, following the same pattern as the rest of the
spans. Due to this, and because a navigation span will always have that
fixed span name, it is no longer necessary to accept the span name as
input for the method.

common/frame_session.go

@@ -756,8 +756,7 @@ func (fs *FrameSession) onFrameNavigated(frame *cdp.Frame, initial bool) {
 	}
 
 	_, fs.mainFrameSpan = TraceNavigation(
-		fs.ctx, fs.targetID.String(), frame.URL,
-		trace.WithAttributes(attribute.String("navigation.url", frame.URL)),
+		fs.ctx, fs.targetID.String(), trace.WithAttributes(attribute.String("navigation.url", frame.URL)),
 	)
 
 	var (

common/trace.go

@@ -14,7 +14,7 @@ type Tracer interface {
 		ctx context.Context, targetID string, spanName string, opts ...trace.SpanStartOption,
 	) (context.Context, trace.Span)
 	TraceNavigation(
-		ctx context.Context, targetID string, url string, opts ...trace.SpanStartOption,
+		ctx context.Context, targetID string, opts ...trace.SpanStartOption,
 	) (context.Context, trace.Span)
 	TraceEvent(
 		ctx context.Context, targetID string, eventName string, spanID string, opts ...trace.SpanStartOption,
@@ -37,10 +37,10 @@ func TraceAPICall(
 // calls its TraceNavigation implementation. If the Tracer is not present in the given
 // ctx, it returns a noopSpan and the given context.
 func TraceNavigation(
-	ctx context.Context, targetID string, url string, opts ...trace.SpanStartOption,
+	ctx context.Context, targetID string, opts ...trace.SpanStartOption,
 ) (context.Context, trace.Span) {
 	if tracer := GetTracer(ctx); tracer != nil {
-		return tracer.TraceNavigation(ctx, targetID, url, opts...)
+		return tracer.TraceNavigation(ctx, targetID, opts...)
 	}
 	return ctx, browsertrace.NoopSpan{}
 }

tests/tracing_test.go

@@ -102,7 +102,7 @@ func TestTracing(t *testing.T) {
 			js:   fmt.Sprintf("page.goto('%s')", ts.URL),
 			spans: []string{
 				"page.goto",
-				fmt.Sprintf("%s/", ts.URL), // Navigation span
+				"navigation",
 			},
 		},
 		{

trace/trace.go

@@ -77,7 +77,7 @@ func (t *Tracer) TraceAPICall(
 // Posterior calls to TraceEvent or TraceAPICall given the same targetID will try to
 // associate new spans for these actions to the liveSpan created in this call.
 func (t *Tracer) TraceNavigation(
-	ctx context.Context, targetID string, url string, opts ...trace.SpanStartOption,
+	ctx context.Context, targetID string, opts ...trace.SpanStartOption,
 ) (context.Context, trace.Span) {
 	t.liveSpansMu.Lock()
 	defer t.liveSpansMu.Unlock()
@@ -96,7 +96,7 @@ func (t *Tracer) TraceNavigation(
 
 	opts = append(opts, trace.WithAttributes(t.metadata...))
 
-	ls.ctx, ls.span = t.Start(ctx, url, opts...)
+	ls.ctx, ls.span = t.Start(ctx, "navigation", opts...)
 	t.liveSpans[targetID] = ls
 
 	return ls.ctx, ls.span