-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update golangci/golangci-lint Docker tag to v1.55.0 #358
Conversation
|
009fde4
to
56118fa
Compare
.golangci.yml
Outdated
- goconst # Fails if the same strings used in several places but is not a constant. Not very useful. | ||
- inamedparam # Fails if interfaces do not have named params. Not in our code style. | ||
- perfsprint # Suggests using strconv.* instead of fmt.* for printing numbers. Not very practical. | ||
- protogetter # Complains when code reads var.Something if var.GetSomething() exists. Not useful. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pablochacin I'm proposing to disable these new linters as they do not seem very useful to me. LMK your thoughts about it, if you think they can be useful we can re-enable them and make the changes they suggest to the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@roobre I think goconst
may be useful as in general seems a sane convention (even if maybe we don't fully adhere to it). leave it up to you to decide.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reenabled goconst, it was not too hard to please it. I de-splitted some t.Errorf
that were causing it to fire, and added a nolint directive to an iptables rule fragment we use quite a lot.
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. ⚠ Warning: custom changes will be lost. |
This PR contains the following updates:
v1.54.2
->v1.55.0
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.