Skip Starting Recording Container When Recording Mode is Set to SKIP (

#118) * fix: disable recording container Closes gh-117 * refactor: set recording mode directly on created container
grails · Dec 24, 2024 · fa6201f · fa6201f
1 parent 5882fd7
commit fa6201f
Showing 1 changed file with 5 additions and 8 deletions.
diff --git a/src/testFixtures/groovy/grails/plugin/geb/WebDriverContainerHolder.groovy b/src/testFixtures/groovy/grails/plugin/geb/WebDriverContainerHolder.groovy
@@ -98,14 +98,11 @@ class WebDriverContainerHolder {
         }
 
         currentConfiguration = specConfiguration
-        currentContainer = new BrowserWebDriverContainer()
-        if (grailsGebSettings.recordingEnabled) {
-            currentContainer = currentContainer.withRecordingMode(
-                    grailsGebSettings.recordingMode,
-                    grailsGebSettings.recordingDirectory,
-                    grailsGebSettings.recordingFormat
-            )
-        }
+        currentContainer = new BrowserWebDriverContainer().withRecordingMode(
+                grailsGebSettings.recordingMode,
+                grailsGebSettings.recordingDirectory,
+                grailsGebSettings.recordingFormat
+        )
         currentContainer.tap {
             withAccessToHost(true)
             start()