Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backporting to support Grails 6.x with JDK 11 #83

Merged
merged 4 commits into from
Nov 28, 2024
Merged

Backporting to support Grails 6.x with JDK 11 #83

merged 4 commits into from
Nov 28, 2024

Conversation

jdaugherty
Copy link
Contributor

@jdaugherty jdaugherty commented Nov 28, 2024 •
edited
Loading

Fixes #73

sbglasius
sbglasius approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@sbglasius sbglasius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like for 5.x if it works, great work! Thanks!

One comment, which is general:

@Since should be 4.1 and not 4.0

src/testFixtures/groovy/grails/plugin/geb/ContainerAwareDownloadSupport.groovy Outdated Show resolved Hide resolved
@jdaugherty jdaugherty merged commit 8249d57 into grails:4.1.x Nov 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbglasius sbglasius sbglasius approved these changes

@matrei matrei Awaiting requested review from matrei

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdaugherty @sbglasius