Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End to End testing for the publish plugin & clean-up of previously failed changes #375

Merged
merged 14 commits into from
Dec 19, 2024

Conversation

jdaugherty
Copy link
Contributor

This change encompasses:

  • not running publish action on forks
  • not running the release notes action on fork (since secrets aren't available in forks / pull requests)
  • end to end testing support for any gradle plugin in this project (including logging for tests in the action)
  • added several tests for the publish plugin based on past issues
  • publishes of a release using MAVEN_PUBLISH should sign the build
  • added back the url validation when using maven publish (previously validation was happening at configure time which caused failures in assemble)
  • add a warning when projectVersion is being used instead of project.version (longer term I think we may just want to make the release/snapshot determination an environment variable / system property instead of hard coded logic)
  • updated some log statements to match the style of previous code review comments

This ticket does not fully fix #364 but it does help us diagnosis issues as they arise. There are 4 tests marked as pending feature which documents the issues found in #364. I think it may be reasonable that this can't be fixed, but I intend to investigate these further now that we have tests.

@jdaugherty
Copy link
Contributor Author

This now supports build release/snapshot detection via environment variable too.

@jdaugherty jdaugherty merged commit a195d18 into grails:7.0.x Dec 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grails Publish Improvements
4 participants