-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grails 7 #46: update documentation #50
Conversation
…version of the plugin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent Brian! I have made some comments on possible improvements.
Also I get the following warning for the asciidoctor
tasks:
> Task :docs:asciidoctorEpub
2024-12-05T09:59:16.920+01:00 [WorkerExecutor Queue] WARN FilenoUtil : Native subprocess control requires open access to the JDK IO subsystem
Pass '--add-opens java.base/sun.nio.ch=ALL-UNNAMED --add-opens java.base/java.io=ALL-UNNAMED' to enable.
> Task :docs:asciidoctorPdf
2024-12-05T09:59:23.464+01:00 [WorkerExecutor Queue] WARN FilenoUtil : Native subprocess control requires open access to the JDK IO subsystem
Pass '--add-opens java.base/sun.nio.ch=ALL-UNNAMED --add-opens java.base/java.io=ALL-UNNAMED' to enable.
> Task :docs:asciidoctor
2024-12-05T09:59:39.193+01:00 [main] WARN FilenoUtil : Native subprocess control requires open access to the JDK IO subsystem
Pass '--add-opens java.base/sun.nio.ch=ALL-UNNAMED --add-opens java.base/java.io=ALL-UNNAMED' to enable.```
We can fix those here or in another PR.
docs/src/docs/tutorial.adoc
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try to run through this tutorial with a Grails 7 installation. I think you will find things that doesn't work, like some grails commands.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not going to take on getting the tutorial up to speed for Grails 7 in this PR (other than adding the @P
annotation to it), but in order to track this as an ongoing issue I have opened up #51 .
…ce,html to source,xml
Should be fixed. |
No description provided.