Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grails 7 #46: update documentation #50

Merged
merged 6 commits into from
Dec 9, 2024
Merged

Conversation

bkoehm
Copy link
Contributor

@bkoehm bkoehm commented Dec 4, 2024

No description provided.

Copy link
Contributor

@matrei matrei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent Brian! I have made some comments on possible improvements.

Also I get the following warning for the asciidoctor tasks:

> Task :docs:asciidoctorEpub
2024-12-05T09:59:16.920+01:00 [WorkerExecutor Queue] WARN FilenoUtil : Native subprocess control requires open access to the JDK IO subsystem
Pass '--add-opens java.base/sun.nio.ch=ALL-UNNAMED --add-opens java.base/java.io=ALL-UNNAMED' to enable.

> Task :docs:asciidoctorPdf
2024-12-05T09:59:23.464+01:00 [WorkerExecutor Queue] WARN FilenoUtil : Native subprocess control requires open access to the JDK IO subsystem
Pass '--add-opens java.base/sun.nio.ch=ALL-UNNAMED --add-opens java.base/java.io=ALL-UNNAMED' to enable.

> Task :docs:asciidoctor
2024-12-05T09:59:39.193+01:00 [main] WARN FilenoUtil : Native subprocess control requires open access to the JDK IO subsystem
Pass '--add-opens java.base/sun.nio.ch=ALL-UNNAMED --add-opens java.base/java.io=ALL-UNNAMED' to enable.```

We can fix those here or in another PR.

docs/src/docs/installing.adoc Outdated Show resolved Hide resolved
docs/src/docs/usage/acls.adoc Outdated Show resolved Hide resolved
docs/src/docs/usage/acls.adoc Outdated Show resolved Hide resolved
docs/src/docs/usage/domainClasses.adoc Outdated Show resolved Hide resolved
docs/src/docs/usage/serviceMethods.adoc Outdated Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to run through this tutorial with a Grails 7 installation. I think you will find things that doesn't work, like some grails commands.

Copy link
Contributor Author

@bkoehm bkoehm Dec 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not going to take on getting the tutorial up to speed for Grails 7 in this PR (other than adding the @P annotation to it), but in order to track this as an ongoing issue I have opened up #51 .

@bkoehm
Copy link
Contributor Author

bkoehm commented Dec 9, 2024

Excellent Brian! I have made some comments on possible improvements.

Also I get the following warning for the asciidoctor tasks:

> Task :docs:asciidoctorEpub
2024-12-05T09:59:16.920+01:00 [WorkerExecutor Queue] WARN FilenoUtil : Native subprocess control requires open access to the JDK IO subsystem
Pass '--add-opens java.base/sun.nio.ch=ALL-UNNAMED --add-opens java.base/java.io=ALL-UNNAMED' to enable.

> Task :docs:asciidoctorPdf
2024-12-05T09:59:23.464+01:00 [WorkerExecutor Queue] WARN FilenoUtil : Native subprocess control requires open access to the JDK IO subsystem
Pass '--add-opens java.base/sun.nio.ch=ALL-UNNAMED --add-opens java.base/java.io=ALL-UNNAMED' to enable.

> Task :docs:asciidoctor
2024-12-05T09:59:39.193+01:00 [main] WARN FilenoUtil : Native subprocess control requires open access to the JDK IO subsystem
Pass '--add-opens java.base/sun.nio.ch=ALL-UNNAMED --add-opens java.base/java.io=ALL-UNNAMED' to enable.```

We can fix those here or in another PR.

Should be fixed.

@bkoehm bkoehm merged commit dfc6776 into grails:5.0.x Dec 9, 2024
3 checks passed
@bkoehm bkoehm mentioned this pull request Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants