Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Development [PENDING] #7

Open
wants to merge 43 commits into
base: dev
Choose a base branch
from

Conversation

arcVaishali
Copy link
Contributor

Still pending !

…mmand added and Changed the type field in package.json to module to use ES modules instead of CommonJS. This will enable the use of import/export statements throughout the project and align with modern JavaScript standards.
….prettierrc to update Prettier settings for better code formatting.- Removed .prettierignore from .gitignore to ensure it is tracked in the repository.This update ensures consistent formatting rules across the project and tracks the .prettierignore file for better collaboration.
@allantito
Copy link
Contributor

Task linked: CU-86b0zrmdz API Development

Copy link

netlify bot commented Jun 22, 2024

Deploy Preview for lakshyaentertainment failed. Why did it fail? →

Name Link
🔨 Latest commit 5441c5f
🔍 Latest deploy log https://app.netlify.com/sites/lakshyaentertainment/deploys/667968049ac5900008060acc


const router = Router();

router.route('/shows').get(

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assumming the route will be defined as "api/v1/shows" in app.js then you should simply this route to "/"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assumming the route will be defined as "api/v1/shows" in app.js then you should simply this route to "/"

Okay I will make the said changes

getShows
);

router.route('/post/shows').post(

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not recommended to include the HTTP action being performed in the route path. this could just be "/show"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay sir, will change

@ryanRATM
Copy link

@arcVaishali I recommend you split up this PR into several smaller ones as there is a lot of code to review.
i do have a major concern with your data modal/schema approach, it is going to cause performance issues with mongodb. I recommended either reviewing your data architecture or using a different database
https://www.dragonflydb.io/faq/mongodb-join-performance
https://www.mongodb.com/resources/products/capabilities/performance-best-practices

@arcVaishali
Copy link
Contributor Author

@arcVaishali I recommend you split up this PR into several smaller ones as there is a lot of code to review. i do have a major concern with your data modal/schema approach, it is going to cause performance issues with mongodb. I recommended either reviewing your data architecture or using a different database https://www.dragonflydb.io/faq/mongodb-join-performance https://www.mongodb.com/resources/products/capabilities/performance-best-practices

Will do it soon👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants