-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API Development [PENDING] #7
base: dev
Are you sure you want to change the base?
Conversation
…mmand added and Changed the type field in package.json to module to use ES modules instead of CommonJS. This will enable the use of import/export statements throughout the project and align with modern JavaScript standards.
….prettierrc to update Prettier settings for better code formatting.- Removed .prettierignore from .gitignore to ensure it is tracked in the repository.This update ensures consistent formatting rules across the project and tracks the .prettierignore file for better collaboration.
…tion, likes, comments, reviews, watchlist
…package.json changed to support ES import of dotenv/config (dev command changed) and Database name added- Entertainify
…gate-paginate-v2 and multer packages added for authentication, files upload and cors
…ad on cloudinary utility added
Task linked: CU-86b0zrmdz API Development |
❌ Deploy Preview for lakshyaentertainment failed. Why did it fail? →
|
…on added and async function handler added
|
||
const router = Router(); | ||
|
||
router.route('/shows').get( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
assumming the route will be defined as "api/v1/shows" in app.js then you should simply this route to "/"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
assumming the route will be defined as "api/v1/shows" in app.js then you should simply this route to "/"
Okay I will make the said changes
getShows | ||
); | ||
|
||
router.route('/post/shows').post( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not recommended to include the HTTP action being performed in the route path. this could just be "/show"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay sir, will change
@arcVaishali I recommend you split up this PR into several smaller ones as there is a lot of code to review. |
Will do it soon👍 |
Still pending !