-
-
Notifications
You must be signed in to change notification settings - Fork 575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce step cache to reduce load on deduplicate #2279
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oad safely, thereby reducing planning time for many larger queries.
🦋 Changeset detectedLatest commit: ee30542 The changes in this PR will be included in the next version bump. This PR includes changesets to release 15 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This reduces the planning time of @slaskis' reproduction from ~6.25s to ~1.26s - i.e. it's now 5x as fast. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Deduplicate is expensive; this new step cache enables the duplicate steps to not be created in the first place, reducing the load on deduplicate. By carefully controlling the way in which steps can be cached (and when these caches need to be cleared) we can enable this functionality safely without risking the complexities that would occur with more naive approaches.
Performance impact
Should reduce planning time for most queries, however the act of writing to the cache does incur some performance penalty so it's certainly possible that some queries will be slower than before. I expect them to be faster in the vast majority of cases.
Security impact
Reduced memory usage (and time usage) during planning should reduce security threats slightly.
Checklist
yarn lint:fix
passes.yarn test
passes.RELEASE_NOTES.md
file (if one exists).