feat: resolve PR comments

1. Removes unnecessary TODO comments
2. Replaces `starknet-core` with `starknet-ff` to minimize deps
3. Fixes expensive `transaction` clone
4. Other misc changes

chain/starknet/Cargo.toml

@@ -12,7 +12,8 @@ hex = { version = "0.4.3", features = ["serde"] }
 prost = { workspace = true }
 prost-types = { workspace = true }
 serde = "1.0"
-starknet-core = "0.6.0"
+sha3 = "0.10.8"
+starknet-ff = "0.3.4"
 
 graph-runtime-wasm = { path = "../../runtime/wasm" }
 graph-runtime-derive = { path = "../../runtime/derive" }

chain/starknet/src/adapter.rs

@@ -5,11 +5,6 @@ use crate::{
     Chain,
 };
 
-// Currently `TriggerFilter` is useless, as it doesn't really filter anything from the block
-// stream, and the complete stream is always consumed, regardless of what the subgraph is indexing.
-// This is very bad for indexing performance and must be implemented for it to be considered
-// production-ready.
-// TODO: implement trigger filter for much better performance
 #[derive(Default, Clone)]
 pub struct TriggerFilter;
 

chain/starknet/src/chain.rs

@@ -55,15 +55,6 @@ pub struct FirehoseMapper {
 
 pub struct TriggersAdapter;
 
-// impl Chain {
-//     pub fn new(
-//         logger_factory: LoggerFactory,
-//         name: String,
-//         registry: Arc<dyn MetricsRegistry>,
-//         firehose_endpoints: FirehoseEndpoints,
-//         chain_store: Arc<dyn ChainStore>,
-//         block_stream_builder: Arc<dyn BlockStreamBuilder<Self>>,
-// ) -> Self {
 impl BlockchainBuilder<Chain> for BasicBlockchainBuilder {
     fn build(self, _config: &Arc<EnvVars>) -> Chain {
         Chain {
@@ -383,31 +374,28 @@ impl TriggersAdapterTrait<Chain> for TriggersAdapter {
         panic!("Should never be called since not used by FirehoseBlockStream")
     }
 
-    // Used for reprocessing blocks when creating a data source.
     #[allow(unused)]
     async fn triggers_in_block(
         &self,
         logger: &Logger,
         block: codec::Block,
         filter: &crate::adapter::TriggerFilter,
     ) -> Result<BlockWithTriggers<Chain>, Error> {
-        // We can't do any filtering here as `TriggerFilter` is useless.
-        // TODO: implement trigger filtering once `TriggerFilter` actually does something.
-
         let shared_block = Arc::new(block.clone());
 
         let mut triggers: Vec<_> = shared_block
             .transactions
             .iter()
             .flat_map(|transaction| -> Vec<StarknetTrigger> {
+                let transaction = Arc::new(transaction.clone());
                 transaction
                     .events
                     .iter()
                     .map(|event| {
                         StarknetTrigger::Event(StarknetEventTrigger {
                             event: Arc::new(event.clone()),
                             block: shared_block.clone(),
-                            transaction: Arc::new(transaction.clone()),
+                            transaction: transaction.clone(),
                         })
                     })
                     .collect()

chain/starknet/src/codec.rs

@@ -1,7 +1,6 @@
-#[allow(clippy::all)]
 #[rustfmt::skip]
 #[path = "protobuf/zklend.starknet.r#type.v1.rs"]
-pub mod pbcodec;
+mod pbcodec;
 
 use graph::blockchain::{Block as BlockchainBlock, BlockHash, BlockPtr};