fix: add test to ensure only bots are configured as single approver a…

…uthors

bot/internal/review/review.go

@@ -60,7 +60,7 @@ var (
 
 	// singleApproverAuthors defines pull request authors in cloud or core repos that only
 	// require a single approver. The map key is the repo (cloud|teleport|teleport.e) and the
-	// value is a list of authors.
+	// value is a list of authors. BOTS ONLY - DO NOT INCLUDE EMPLOYEE GITHUB HANDLES.
 	singleApproverAuthors = map[string][]string{
 		"cloud": []string{Dependabot, DependabotBatcher, RenovateBotPrivate, RenovateBotPublic},
 	}

bot/internal/review/review_test.go

@@ -17,6 +17,7 @@ limitations under the License.
 package review
 
 import (
+	"slices"
 	"sort"
 	"testing"
 
@@ -1192,6 +1193,21 @@ func TestPreferredReviewers(t *testing.T) {
 	}
 }
 
+func TestSingleApproverAuthors(t *testing.T) {
+	name := func(authors []string, i int) string {
+		if i == -1 {
+			return ""
+		}
+		return authors[i]
+	}
+	for repo, authors := range singleApproverAuthors {
+		i := slices.IndexFunc(authors, func(author string) bool {
+			return !isAllowedRobot(author)
+		})
+		require.Equal(t, -1, i, "%q is not allowed to be a single approver author in the %q repository (only bots)", name(authors, i), repo)
+	}
+}
+
 const reviewers = `
 {
 	"codeReviewers": {