env-loader: bug fixes #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it possible to write some tests to lock in this behavior? |
r0mant
approved these changes
Nov 22, 2024
zmb3
reviewed
Nov 26, 2024
| for _, test := range tests { | ||
| actualValues, err := getRequestedEnvValues(test.c) | ||
| require.NoError(t, err) | ||
| require.EqualValues(t, actualValues, test.expectedValues) |
There was a problem hiding this comment.
I think you've got the order backwards here. I'm pretty sure it should be expected values, then actual values.
In Teleport we have a linter enabled that catches a lot of these.
There was a problem hiding this comment.
In Teleport we have a linter enabled that catches a lot of these.
Do you happen to know what it is/how it's configured? I setup this to standardize how we lint across the projects in this repo. It'd be great to get this enabled for everything.
There was a problem hiding this comment.
We run testifylint via golangci-lint: https://github.com/gravitational/teleport/blob/master/.golangci.yml#L252-L264
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the following bugs with the env loader tool:
environments-directoryarg shared an environment variable with theenvironmentsarg/character in them would search individual components instead of the full path (i.e..environments/stageand.environments/buildinstead of.environments/stage/build)