Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump google.golang.org/grpc to v1.69.2 #50543

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

codingllama
Copy link
Contributor

@codingllama codingllama commented Dec 23, 2024

Bump grpc-go to the latest version.

In recent versions grpc-go "swallowed" the google.golang.org/grpc/stats/opentelemetry module, which causes some build difficulties for projects that have both "new" and "old" grpc-go versions in their build graphs (which we do).

@codingllama codingllama added the no-changelog Indicates that a PR does not require a changelog entry label Dec 23, 2024
@codingllama codingllama requested a review from tigrato December 23, 2024 13:41
@codingllama
Copy link
Contributor Author

codingllama commented Dec 23, 2024

Both cloud.google.com/go/storage and fsouza/fake-gcs-server (at the least) have stats/opentelemetry in their module graph. Cloud storage has updated past the "problematic" grpc-go versions, but fsource/fake-gcs-server hasn't. That means we need the exclude, so I have not updated Cloud storage here.

@codingllama codingllama force-pushed the codingllama/bump-grpc branch from 42c6a42 to a8beca5 Compare December 23, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants