feat(RadioButton): redesign to increase contrast in component #1742
Conversation
|
Preview is ready. |
|
Visual Tests Report is ready. |
| z-index: -1; | ||
| inset: 3px; | ||
| border-radius: var(--_--border-radius-inner); | ||
| z-index: -2; |
There was a problem hiding this comment.
In which case is z-index: -1 not sufficient?
There was a problem hiding this comment.
I forgot to return it back to -1 after testing different layout options.
Fixed it
benax-se
force-pushed
the
feat/radio-button-increase-contrast-redesign
branch
from
7bf7b69 to
2c3848e
Compare
|
This PR might be fixing the issue #1923 |
|
@amje looks like this PR could soulve this problem, yes, is there eta when this PR could be merged? |
|
|
||
| &-outline { | ||
| &::before { |
There was a problem hiding this comment.
What is the reason to use pseudo-elements? Why just don't change border and of element itself?
There was a problem hiding this comment.
Because on the touching sides of the buttons it will cause double border, which is visible while using semitransparent colors (they are used in base theme)
Also there were bunch of problems with overflow state (can not remember details of it now)
Closes #1732