Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test change #7

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test change #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 12 additions & 11 deletions dangerfile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
//
// `DANGER_GITHUB_API_TOKEN=[ENV_ABOVE] yarn danger pr https://github.com/facebook/react/pull/11865

// This is a test change
const {markdown, danger, warn} = require('danger');
const fetch = require('node-fetch');

Expand Down Expand Up @@ -66,7 +67,7 @@ function generateMDTable(headers, body) {
headers.map(() => ' --- ').join(' | '),
];

const tablebody = body.map(r => r.join(' | '));
const tablebody = body.map((r) => r.join(' | '));
return tableHeaders.join('\n') + '\n' + tablebody.join('\n');
}

Expand Down Expand Up @@ -94,7 +95,7 @@ function addPercent(change, includeEmoji) {

function setBoldness(row, isBold) {
if (isBold) {
return row.map(element => `**${element}**`);
return row.map((element) => `**${element}**`);
} else {
return row;
}
Expand All @@ -105,7 +106,7 @@ function setBoldness(row, isBold) {
* and master.
*/
function git(args) {
return new Promise(res => {
return new Promise((res) => {
exec('git ' + args, (err, stdout, stderr) => {
if (err) {
throw err;
Expand All @@ -116,7 +117,7 @@ function git(args) {
});
}

(async function() {
(async function () {
// Use git locally to grab the commit which represents the place
// where the branches differ
const upstreamRepo = danger.github.pr.base.repo.full_name;
Expand Down Expand Up @@ -196,11 +197,11 @@ function git(args) {

const packagesToShow = results
.filter(
r =>
(r) =>
Math.abs(r.prevFileSizeAbsoluteChange) >= 300 || // bytes
Math.abs(r.prevGzipSizeAbsoluteChange) >= 100 // bytes
)
.map(r => r.packageName);
.map((r) => r.packageName);

if (packagesToShow.length) {
let allTables = [];
Expand All @@ -210,7 +211,7 @@ function git(args) {

if (packagesToShow.includes('react')) {
const reactProd = results.find(
r => r.bundleType === 'UMD_PROD' && r.packageName === 'react'
(r) => r.bundleType === 'UMD_PROD' && r.packageName === 'react'
);
if (
reactProd.prevFileSizeChange !== 0 ||
Expand All @@ -224,7 +225,7 @@ function git(args) {

if (packagesToShow.includes('react-dom')) {
const reactDOMProd = results.find(
r => r.bundleType === 'UMD_PROD' && r.packageName === 'react-dom'
(r) => r.bundleType === 'UMD_PROD' && r.packageName === 'react-dom'
);
if (
reactDOMProd.prevFileSizeChange !== 0 ||
Expand All @@ -240,9 +241,9 @@ function git(args) {

// eslint-disable-next-line no-var,no-for-of-loops/no-for-of-loops
for (var name of new Set(packagesToShow)) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Consider using let instead of var for better scoping.

Comment on lines 242 to 243
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Using 'var' with for-of can cause scoping issues. Consider using 'const' or 'let' instead.

const thisBundleResults = results.filter(r => r.packageName === name);
const thisBundleResults = results.filter((r) => r.packageName === name);
const changedFiles = thisBundleResults.filter(
r => r.prevFileSizeChange !== 0 || r.prevGzipSizeChange !== 0
(r) => r.prevFileSizeChange !== 0 || r.prevGzipSizeChange !== 0
);

const mdHeaders = [
Expand All @@ -256,7 +257,7 @@ function git(args) {
'ENV',
];

const mdRows = changedFiles.map(r => {
const mdRows = changedFiles.map((r) => {
const isProd = r.bundleType.includes('PROD');
return setBoldness(
[
Expand Down