Add new hexpired notification for HFE #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
- Added 'hexpired' notification for hash field expirations
- Updated
tests/unit/pubsub.tclto include tests for 'hexpired' notifications - Tests cover active expiration, lazy expiration, and immediate expiration using h(p)expire(at) commands
- Ensured single 'hexpired' notification for multiple field expirations in
hmget - Prevented redundant notifications when fields with TTL are deleted by commands like
hdel
1 file(s) reviewed, no comment(s)
![greptile-apps-local[bot]](https://avatars.githubusercontent.com/u/140149887?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
- Added
hexpirednotification for hash field expirations - New test cases for active, lazy, and immediate expirations
- Ensured single
hexpirednotification for multiple expirations inhmget - Prevented notifications for TTL fields deleted by commands like
hdel
There was a problem hiding this comment.
PR Summary
- Added
hexpirednotification for hash field expirations - New tests for
hexpirednotification intests/unit/pubsub.tcl - Ensure notifications for active, lazy, and immediate expirations
- Single notification for multiple field expirations in
hmget - No notification for TTL field deletions without global DS update
There was a problem hiding this comment.
PR Summary
- Added 'hexpired' notification for hash field expiration
- New tests for 'hexpired' notification in
tests/unit/pubsub.tcl - Covered active, lazy, and immediate expiration scenarios
- Improved notification handling for multiple field expirations in
hmget - Ensured no notification for TTL field deletion without global DS update
1 file(s) reviewed, no comment(s)
1. send "hexpired" notification first and then "del" 2. add signalModifiedKey() in hashTypeGetValue() Co-authored-by: Ozan Tezcan <[email protected]> Co-authored-by: Moti Cohen <[email protected]>
There was a problem hiding this comment.
PR Summary
(updates since last review)
- Added
hexpirednotification for hash field expirations - Modified
lookupKeyByPatterninsrc/sort.cforHFE_LAZY_EXPIRE - Updated TTL values in
tests/integration/rdb.tcl - Added test cases for
hexpiredintests/unit/moduleapi/hash.tclandscan.tcl - Updated expiration logic and tests in
tests/unit/type/hash-field-expire.tcl
5 file(s) reviewed, no comment(s)
Co-authored-by: Ozan Tezcan <[email protected]>
There was a problem hiding this comment.
PR Summary
(updates since last review)
- Added tests for
hexpirednotification feature - Ensure notifications for active and lazy expiration of hash fields
- Verify single notification for multiple field expirations
- Check for
delnotification after all fields expire
1 file(s) reviewed, no comment(s)
Co-authored-by: Ozan Tezcan <[email protected]>
There was a problem hiding this comment.
PR Summary
(updates since last review)
- Added
hexpirednotification for hash field expiration - New tests for
hexpirednotification intests/unit/pubsub.tcl - Scenarios covered: active expiration, lazy expiration, command-triggered expiration
- Single
hexpirednotification for multiple field expirations inhmget - No notification for TTL field deletions without global DS update
1 file(s) reviewed, no comment(s)
|
References: redis#13329 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the hash field expired, we will send a new hexpired notification.
It mainly includes the following three cases:
h(p)expire(at) command, the user will also get ahexpirednotification if the field expires during the command.Improvement
hexpirednotification.