Eclipse 4.34 (RC2) JDT Patch for Groovy-Eclipse

https://github.com/eclipse-jdt/eclipse.jdt.core/releases/tag/S4_34_0_RC2

for #1597 #1598

groovy-eclipse.setup

@@ -305,13 +305,13 @@
       <requirement
           name="org.eclipse.test.feature.group"/>
       <repositoryList
-          name="2023-06">
+          name="2024-12">
         <repository
             url="https://download.eclipse.org/releases/2024-12"/>
         <repository
             url="https://download.eclipse.org/eclipse/updates/4.34"/>
         <repository
-            url="https://download.eclipse.org/eclipse/updates/4.34-I-builds/I20241113-1800"/>
+            url="https://download.eclipse.org/eclipse/updates/4.34-I-builds/I20241120-1800"/>
       </repositoryList>
       <repositoryList
           name="2024-09">

jdt-patch/e434/Feature-org.codehaus.groovy.jdt.patch/feature.xml

@@ -18,7 +18,7 @@
    </license>
 
    <requires>
-      <import feature="org.eclipse.jdt" version="3.20.0.v20241113-1800" patch="true"/>
+      <import feature="org.eclipse.jdt" version="3.20.0.v20241120-1800" patch="true"/>
    </requires>
 
    <plugin

jdt-patch/e434/org.eclipse.jdt.core/codeassist/org/eclipse/jdt/internal/codeassist/DOMCodeSelector.java

@@ -227,7 +227,7 @@ public IJavaElement[] codeSelect(int offset, int length) throws JavaModelExcepti
 					/* GROOVY edit
 					variableBinding.getDeclaringMethod() instanceof IMethodBinding declaringMethod &&
 					declaringMethod.isCompactConstructor() &&
-					Arrays.stream(declaringMethod.getParameterNames()).anyMatch(pn -> variableBinding.getName().equals(pn)) &&
+					Arrays.stream(declaringMethod.getParameterNames()).anyMatch(variableBinding.getName()::equals) &&
 					declaringMethod.getDeclaringClass() instanceof ITypeBinding recordBinding &&
 					recordBinding.isRecord() &&
 					recordBinding.getJavaElement() instanceof IType recordType &&

jdt-patch/e434/org.eclipse.jdt.core/model/org/eclipse/jdt/internal/core/DeltaProcessor.java

@@ -30,6 +30,7 @@
 import java.util.Set;
 import org.eclipse.core.resources.*;
 import org.eclipse.core.runtime.CoreException;
+import org.eclipse.core.runtime.ILog;
 import org.eclipse.core.runtime.IPath;
 import org.eclipse.core.runtime.IProgressMonitor;
 import org.eclipse.core.runtime.ISafeRunnable;
@@ -2022,7 +2023,9 @@ public void resetProjectCaches() {
 	 */
 	public void registerJavaModelDelta(IJavaElementDelta delta) {
 		if (JavaModelManager.isReadOnly()) {
-			throw new IllegalStateException("Its not allow to modify JavaModel during ReadOnly action. delta=" + delta); //$NON-NLS-1$
+			ILog.get().warn("JavaModel change during read only operation", new IllegalStateException( //$NON-NLS-1$
+					"JavaModel modified during 'read only' operation. Consider to report this warning to https://github.com/eclipse-jdt/eclipse.jdt.core/issues. delta=" //$NON-NLS-1$
+							+ delta));
 		}
 		this.javaModelDeltas.add(delta);
 	}

pom.xml

@@ -108,7 +108,7 @@
 				<repository>
 					<id>milestone</id>
 					<layout>p2</layout>
-					<url>https://download.eclipse.org/eclipse/updates/4.34-I-builds/I20241113-1800</url>
+					<url>https://download.eclipse.org/eclipse/updates/4.34-I-builds/I20241120-1800</url>
 				</repository>
 			</repositories>
 			<modules>