Group 22 modifications #35
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
growlf
requested changes
Feb 25, 2024
| @@ -34,7 +34,8 @@ | |||
| "installTools": true, | |||
| "version": "3.11" | |||
| }, | |||
| "ghcr.io/warrenbuckley/codespace-features/sqlite:1": {} | |||
| "ghcr.io/warrenbuckley/codespace-features/sqlite:1": {}, | |||
| "ghcr.io/meaningful-ooo/devcontainer-features/homebrew:2": {} | |||
There was a problem hiding this comment.
This might add some useful compatibility for people on Macs.
| RUN /bin/bash -c "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/HEAD/install.sh)" | ||
|
|
||
| # Add homebrew to the path | ||
| ENV PATH="/home/linuxbrew/.linuxbrew/bin:/home/linuxbrew/.linuxbrew/sbin:$PATH" |
There was a problem hiding this comment.
This assumes the user has this folder in their host environment. Perhaps, move this mount action to the docker-compose.yml where it can be selectively run when selecting which service to bring up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added homebrew installation to dockerfile and added homebrew feature to devcontainer