Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore case for boolean option values in protoc-gen-grpc-swift #20

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

glbrntt
Copy link
Collaborator

@glbrntt glbrntt commented Dec 11, 2024

Motivation:

The protoc-gen-grpc-swift plugin has a few boolean options which currently require a lowercased value. This is overly strict, the casing of "true"/"false" shouldn't matter.

Modifications:

  • Ignore case for boolean optioned values

Result:

Easier to use protoc-gen-grpc-swift

Motivation:

The protoc-gen-grpc-swift plugin has a few boolean options which
currently require a lowercased value. This is overly strict, the casing
of "true"/"false" shouldn't matter.

Modifications:

- Ignore case for boolean optioned values

Result:

Easier to use protoc-gen-grpc-swift
@glbrntt glbrntt requested a review from gjcairo December 11, 2024 07:58
@glbrntt glbrntt added the 🔨 semver/patch No public API change. label Dec 11, 2024
@glbrntt glbrntt enabled auto-merge (squash) December 11, 2024 07:58
@glbrntt glbrntt merged commit 9b79693 into grpc:main Dec 12, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 semver/patch No public API change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants