DO NOT MERGE: Patch: Handle bad manifests with more logging and retries #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guyboltonking
changed the base branch from
main
to
guy/EEESUPPORT-11240/do-not-merge-tweak-layout-for-bazel-gazelle-module
guyboltonking
changed the title
guyboltonking
commented
Aug 22, 2024
| } | ||
|
|
||
| if err := validateMediaType(ctx, p, desc.MediaType); err != nil { | ||
| return nil, fmt.Errorf("children: invalid desc %s: %w", desc.Digest, err) |
There was a problem hiding this comment.
This is the error we've been seeing, with a JSON error in err, which suggests that the json.Unmarshal call in validateMediaType is where we're failing. That in turn suggests we need to retry the ReadBlob and the validateMediaType, which is why we extract readValidatedManifestBlob and wrap it in readValidatedManifestBlobWithRetry.
guyboltonking
commented
Aug 22, 2024
|
|
||
| retriesRemaining -= 1 | ||
|
|
||
| time.Sleep(time.Duration(readValidatedManifestBlobDelaySeconds) * time.Second) |
There was a problem hiding this comment.
This should be fine, since time.Sleep is meant to interact safely with goroutines (which is what this is called within).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a patch in support of DataDog/rules_oci#62; it should be reviewed in tandem.