Release v0.9.0 #385
Merged
Release v0.9.0 #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- get layer name by splitting on underscore - start numbering at 0
implement suggestions by @vincentpost
Add information about geotop stratigraphic units
layer "NA" would result in NaN
…d not contain data
To solve some warnings
* Update ahn.py * Fix codacy issues * Add explanation for identifier
* Update tile retreival ahn.py - On the eclipse server: Skip tile retreival if the link does not exist. - Legacy server: Rasterio merge returned only zero's since 17 sept. All the merging is now done within xarray. * Pleasing codacy * Revert changes to legacy functions
- compute isosurface, e.g. depth at which concentration exceeds a threshold value.
* prepare time and sim modules for cftime * update get_time_idx for cftime * ruff * fix some small errors * add option for float time * ensure time index is float not int * ruff * comments Davíd * codacy * pin numpy * fix errors
(useful when reading in model results in separate scripts).
- default to float time index - fix for minor error introduced in #375
* Add zonal_statistics and replace add_info_to_gdf And add test * Add rasterstats to optional dependencies and solve warning in tests * Rename add_info_to_gdf to gdf_intersection_join and add docstring * Remove pandas<2.1.0 dependency, to solve ci bug * Also remove netCDF4<1.7.0 * Pin numpy on 1.26.4
- address comments @rubencalje - add test
to accept both ds.time and ds
* use local file if ellips server returns a HTTPError * ruff fixes * fix some imports
* add bronhouder names * make a function that gets the bgt names * add bronhouder name test to see if they are up to date * add note on how the dictionary is made. * add check for date, not only year
Small improvements
* Add optional kwargs to sim * Improve docstring of get_bgt * Improve lake_from_gdf * Add get_icell2d_from_xy * Replace tight_layout by layout="constrained" in get_map * Fix codacy issue * Cut meteorological data from ds for lake in separate method * Add get_row_col_from_xy and improve get_head_at_point * Also set "numpy==1.26.4" for the documentation * Fix codacy issue and test and remove tight layout from _get_figure * set tight_layout again in map_array * Fix bug when recharge or evaporation did not contain a time dimension * Improve storage of ahn tiles * Update test_check_ahn_files_up_to_date * Remove band of merged arrays (which is needed in rioxarray version 0.18.0 * Do not drop band twice * Standardise xarray in docstrings of grid * Rename cut to clip in lake-methods * I before e except after c --------- Co-authored-by: Davíd Brakenhoff <[email protected]>
- add method to get configuration - add method to download index (geodataframe) - add method to download bathymetry data as xr.DataArray - add tests
* Add get_seaonal_timeseries, and add start_summer and start_winter parameters in gdf_to_seasonal_pkg Also improve some docstrings * Fix codacy issues and add test for get_seaonal_timeseries
* Add between_layers to calculate_resistance, and set to False * Implement changes requested by @dbrakenhoff
add RWS bathymetry to nlmod.read.rws
|
The NHI-GWO database does not return data for Brabant Water anymore, which is the reason this tests in the PRs was failing. I sent a mail to the NHI helpdesk, with a question why this is the case. For now, maybe we can change the test to a well field of another drinking water company, for example Vitens. |
bad operand type for unary ~: NoneType (invalid-unary-operand-type)
…t_icell2d_from_xy And ignore nans in get_isosurface_1d
OnnoEbbens
requested changes
Nov 25, 2024
OnnoEbbens
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.