Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add RWS bathymetry to nlmod.read.rws #388

Merged
merged 4 commits into from
Nov 18, 2024
Merged

add RWS bathymetry to nlmod.read.rws #388

merged 4 commits into from
Nov 18, 2024

Conversation

dbrakenhoff
Copy link
Collaborator

  • add method to get configuration
  • add method to download index (geodataframe)
  • add method to download bathymetry data as xr.DataArray
  • add tests

- add method to get configuration
- add method to download index (geodataframe)
- add method to download bathymetry data as xr.DataArray
- add tests
Copy link
Collaborator

@rubencalje rubencalje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition! I would change the following minor points:

  • I would change the default resolution to 20m (unless there is a good reason for the fine resolution)
  • I would add an optional parameter config to get_bathymetry_gdf and get_bathymetry, with a value of None that is replaced by the output of get_gdr_configuration when None. IN this way, when the url changes, the user can edit the configuration without a new nlmod version.

@dbrakenhoff
Copy link
Collaborator Author

The larger resolution does not return data for the major rivers, only the sea, IJsselmeer (I think) and estuaries. So I'm fine with either as the default, but there is a difference in the area both resolutions cover.

And good idea for the config, I'll add that.

@dbrakenhoff
Copy link
Collaborator Author

test fails unrelated.

@dbrakenhoff dbrakenhoff merged commit ecaa33b into dev Nov 18, 2024
2 of 3 checks passed
@dbrakenhoff dbrakenhoff deleted the bathymetry branch November 18, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants