# 11 - [WARNING] /path/to/SomeType.java found raw type: org.gwtproject.editor.client.adapters.SimpleEditor missing type arguments... - fixed #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gwtproject.editor.client.adapters.SimpleEditor missing type arguments... - done
FrankHossfeld
changed the title
|
@vegegoku can you review, please. Thanks |
vegegoku
previously approved these changes
Jul 2, 2023
|
CI needs to be updated to a min of Java 11 gwt-editor/.github/workflows/build.yaml Line 31 in 37921b6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will remove the warnings mentioned in issue #11.
Were able to remove most of the warnings. A few aren't able to remove (the cast stuff). There a @SuppressWarnings("unchecked") is added.
All tests are ok, tested the HEAD-SNAPSHOT locally. Looks good to me.